[libvirt] [PATCH v2 2/3] docs: move javascript logic into a standalone file

Andrea Bolognani abologna at redhat.com
Fri Apr 5 15:45:10 UTC 2019


On Fri, 2019-04-05 at 17:38 +0200, Andrea Bolognani wrote:
> On Fri, 2019-04-05 at 16:12 +0100, Daniel P. Berrangé wrote:
> > Instead of duplicating javascript in every single page, put it in a
> > standalone file which can be cached by the browser.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> >  docs/Makefile.am |  1 +
> >  docs/main.js     | 25 +++++++++++++++++++++++++
> >  docs/page.xsl    | 35 +++--------------------------------
> >  3 files changed, 29 insertions(+), 32 deletions(-)
> >  create mode 100644 docs/main.js
> 
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>

Actually, not so fast: you've moved the existing JavaScript code
to docs/main.js instead of js/docs/main.js, which is of course
completely wrong. Please fix that before pushing.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list