[libvirt] [PATCH 0/6] readline: Drop obsolete code, add pkg-config support

Andrea Bolognani abologna at redhat.com
Tue Apr 9 13:10:17 UTC 2019


This series drops a bunch of compatibility code that's no longer
necessary to support our target platforms and introduces support
for getting readline's CFLAGS and LIBS via pkg-config, which in
turn makes it possible to automatically enable the feature on
FreeBSD.

There are a couple of caveats:

  * while most of the existing kludges are dropped, a new one had
    to be introduced :( The upsides are that the new kludge is small
    and straightforward, and that there's an expiration date on it
    already, since a patch making it unnecessary has already been
    provided for upstream readline;

  * autodetection on macOS still doesn't work because of a
    downstream packaging issue, but that's not any worse than the
    current situation anyway.

Andrea Bolognani (6):
  tools: vsh: Drop obsolete readline compatibility code
  m4: readline: Extract code setting -D_FUNCTION_DEF
  m4: readline: Stop looking for rl_completion_quote_character()
  m4: readline: Drop extra_LIBS machinery
  m4: readline: Use pkg-config
  m4: readline: Add gross kludge for include path

 m4/virt-readline.m4 | 68 ++++++++++++++++++++++-----------------------
 tools/vsh.c         | 17 ------------
 2 files changed, 33 insertions(+), 52 deletions(-)

-- 
2.20.1




More information about the libvir-list mailing list