[libvirt] [PATCH v4 6/7] tests: add cross compiler images to CI test help output

Andrea Bolognani abologna at redhat.com
Wed Apr 10 11:36:19 UTC 2019


On Wed, 2019-04-03 at 11:41 +0100, Daniel P. Berrangé wrote:
[...]
> +	@echo "Available cross-compiler container images:"
> +	@echo
> +	@echo "    debian-[9,sid]-cross-aarch64"

All these should look either like

  debian-{9,sid}-cross-...

(shell style, my personal preference) or

  debian-(9|sid)-cross-...

(regex style): the style you've chosen here is not really something
I've seen around, better to stick with something more common.

With that addressed, and the patch squashed into 1/7,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list