[libvirt] [PATCH] tests: Fix MinGW build for domaincapstest
Michal Privoznik
mprivozn at redhat.com
Wed Apr 10 13:49:23 UTC 2019
On 4/10/19 3:31 PM, Andrea Bolognani wrote:
> Commit 5b9819eedc71 started using the virFileWrapper APIs in
> the test program, and correctly called them only in the section
> of code guarded by WITH_QEMU; however, a single call to the
> virFileWrapperClearPrefixes() function ended up in the
> hypervisor-agnostic section, causing a build failure on MinGW.
>
> Move the call to the QEMU-only section; while at it, also drop
> the virFileWrapperRemovePrefix() calls, which are entirely
> redundant since we'd drop all prefixes immediately afterwards
> anyway.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>
> Another approach would be to simply drop the call to
> virFileWrapperClearPrefixes(), but there really is no point
> in removing prefixes one by one when we can just clear all of
> them in one fell swoop.
>
> tests/domaincapstest.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Okay, let's go with this approach. ACK
Michal
More information about the libvir-list
mailing list