[libvirt] [PATCH for v5.3.0 03/17] virfile: Make virFileGetXAttr report errors

Cole Robinson crobinso at redhat.com
Wed Apr 10 20:05:45 UTC 2019


On 3/28/19 11:04 AM, Michal Privoznik wrote:
> The way that security drivers use XATTR is kind of verbose. If
> error reporting was left for caller then the caller would end up
> even more verbose.
> 
> There are two places where we do not want to report error if
> virFileGetXAttr fails. Therefore virFileGetXAttrQuiet is
> introduced as an alternative that doesn't report errors.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/libvirt_private.syms     |  1 +
>  src/security/security_util.c |  4 ++--
>  src/util/virfile.c           | 42 ++++++++++++++++++++++++++++++------
>  src/util/virfile.h           |  5 +++++
>  tests/qemusecuritymock.c     |  6 +++---
>  5 files changed, 46 insertions(+), 12 deletions(-)

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the libvir-list mailing list