[libvirt] [PATCH 0/2] Fix 'New libvirt-tck failure with libvirt 5.2.0'

[Daniel Henrique Barboza]

Hi,

Jim Fehlig reported a failure in a libvirt-tck test after the
patch:

commit f1d6585300001c7b23b8796a0faa4411c3531996
Author: Daniel Henrique Barboza <danielhb413 at gmail.com>
Date:   Fri Mar 15 18:06:45 2019 -0300

    domain_conf: check device address before 

This patch is blocking the use of 'virsh attach-device' for changing
and ejecting  CDROM/Floppy drives. More info and some discussion
can be found at [1].

This small patch set makes changes in the device address
verification to allow this usage back. First patch is just an
extra helper to make the code a bit easier to read. Patch 2
amends commit f1d658530.

[1] https://www.redhat.com/archives/libvir-list/2019-April/msg00733.html

Daniel Henrique Barboza (2):
  domain_conf: adding virDomainDiskIsCdromOrFloppy helper
  domain_conf: allow CDROM/Floppy media change with attach-device

 src/conf/domain_conf.c   | 9 +++++++++
 src/conf/domain_conf.h   | 2 ++
 src/libvirt_private.syms | 1 +
 src/qemu/qemu_command.c  | 3 +--
 src/qemu/qemu_driver.c   | 3 +--
 src/qemu/qemu_hotplug.c  | 6 ++----
 6 files changed, 16 insertions(+), 8 deletions(-)

-- 
2.20.1