[libvirt] [PATCH 3/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'

[Ján Tomko]

On Fri, Apr 12, 2019 at 10:46:41AM +0200, Michal Privoznik wrote:
>The latter is deprecated and will be removed soon. The advised
>replacement is '-overcommit mem-lock=on|off'.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c                               | 11 ++++++++---
> .../channel-unix-guestfwd.x86_64-latest.args          |  2 +-
> .../console-virtio-unix.x86_64-latest.args            |  2 +-
> .../controller-virtio-scsi.x86_64-latest.args         |  2 +-
> tests/qemuxml2argvdata/disk-aio.x86_64-latest.args    |  2 +-

[...]

> .../x86_64-q35-graphics.x86_64-latest.args            |  2 +-
> .../x86_64-q35-headless.x86_64-latest.args            |  2 +-
> tests/qemuxml2argvtest.c                              |  4 ++--
> 81 files changed, 89 insertions(+), 84 deletions(-)
>
>diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
>index 8b517d83aa..5dbb0fc974 100644
>--- a/tests/qemuxml2argvtest.c
>+++ b/tests/qemuxml2argvtest.c
>@@ -2399,8 +2399,8 @@ mymain(void)
>             QEMU_CAPS_DEVICE_PCIE_ROOT_PORT,
>             QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY);
>
>-    DO_TEST("mlock-on", NONE);
>-    DO_TEST("mlock-off", NONE);
>+    DO_TEST("mlock-on", QEMU_CAPS_OVERCOMMIT);
>+    DO_TEST("mlock-off", QEMU_CAPS_OVERCOMMIT);
>     DO_TEST("mlock-unsupported", NONE);
>
>     DO_TEST_PARSE_ERROR("pci-bridge-negative-index-invalid", NONE);

With these switched to DO_TEST_CAPS:
Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190412/738ee959/attachment-0001.sig>