[libvirt] [PATCH 0/7] vbox: drop support for many old versions

Fri Apr 12 11:47:16 UTC 2019

Sorry, this series fails to compile corrrectly. Will re-post.

On Fri, Apr 12, 2019 at 12:05:46PM +0100, Daniel P. Berrangé wrote:
> Per this link:
> 
>   https://www.virtualbox.org/wiki/Download_Old_Builds
> 
>     VirtualBox 6.0 (active maintenance)
>     VirtualBox 5.2 (active maintenance)
>     VirtualBox 5.1 (no longer supported, support ended 2018/04)
>     VirtualBox 5.0 (no longer supported, support ended 2017/05)
>     VirtualBox 4.3 (no longer supported, support ended 2015/12)
>     VirtualBox 4.2 (no longer supported, support ended 2015/12)
>     VirtualBox 4.1 (no longer supported, support ended 2015/12)
>     VirtualBox 4.0 (no longer supported, support ended 2015/12)
> 
> We can certainly drop all the 4.x versions. The host OS those are
> officially supported on are very outdated:
> 
> eg
> 
>   https://www.virtualbox.org/wiki/Download_Old_Builds_4_3
> 
> Linux Hosts:
> 
>     Ubuntu 13.04 ("Raring") / 13.10 ("Saucy") / 14.04 ("Trusty") / 14.10 ("Utopic")  i386 |  AMD64
>     Ubuntu 12.10 ("Quantal")  i386 |  AMD64
>     Ubuntu 12.04 ("Precise")  i386 |  AMD64
>     Ubuntu 10.04 LTS ("Lucid")  i386 |  AMD64
>     Debian 7 ("Wheezy")  i386 | AMD64
>     Debian 6 ("Squeeze")  i386 |  AMD64
>     openSUSE 12.3 / 13.1  i386 |  AMD64
>     openSUSE 11.4 / 12.1 / 12.2  i386 |  AMD64
>     SUSE Linux Enterprise Server 11 (SLES11)  i386 |  AMD64
>     SUSE Linux Enterprise Server 10 (SLES10)  i386 |  AMD64
>     Fedora 18 ("Spherical Cow") / Fedora 19 ("Schrödingers Cat")  i386 |  AMD64
>     Fedora 17 ("Beefy Miracle")  i386 |  AMD64
>     Mandriva 2011.0  i386 |  AMD64
>     Oracle Linux 6 ("OL6") / Red Hat Enterprise Linux 6 ("RHEL6") / CentOS 6  i386 |  AMD64
>     Oracle Linux 5 ("OL5") / Red Hat Enterprise Linux 5 ("RHEL5") / CentOS 5  i386 |  AMD64
>     All distributions  i386 | AMD64
> 
> Although the catch all "All distributions" suggest it might work with
> newer distros, they are clearly a second tier from a support POV. All
> these explicitly targetted distros are outside libvirt's support policy.
> 
> There is a question as to whether to delete 5.0 and 5.1 support from
> libvirt.
> 
> There are no remainining #ifdef VBOX_API_VERSION conditionals in the
> vbox_tmpl.h file related to code differences between 5.0, 5.1 and 5.2,
> so keeping them is not a maint burden in code.
> 
> The main burden is distributing the large vbox_CAPI_v5_0.h and
> vbox_CAPI_v5_1.h files which are ~1 MB in size (uncompressed)
> or ~85 kb (xz compressed). IOW versions 5.0 and 5.1 increase
> the release tarballs by a small amount, but nothing that is
> too unreasonable vs the overall size of 14 MB for libvirt source.
> 
> Thus I have kept 5.0 and 5.1 support.
> 
> VirtualBox 6.0 came out in Dec 2018 and given past practice it
> would not suprise me if that has API changes impacting libvirt.
> So some interested party might want to look at supporting that
> in libvirt.
> 
> Daniel P. Berrangé (7):
>   vbox: drop support for VirtualBox 4.x releases
>   vbox: drop C API definition for release 4.0
>   vbox: drop C API definition for release 4.1
>   vbox: drop C API definition for release 4.2
>   vbox: drop C API definition for release 4.2.20
>   vbox: drop C API definition for release 4.3
>   vbox: drop C API definition for release 4.3.4
> 
>  src/vbox/Makefile.inc.am      |     6 -
>  src/vbox/vbox_CAPI_v4_0.h     |  7451 -----------------------
>  src/vbox/vbox_CAPI_v4_1.h     |  7882 ------------------------
>  src/vbox/vbox_CAPI_v4_2.h     |  8855 ---------------------------
>  src/vbox/vbox_CAPI_v4_2_20.h  |  9001 ----------------------------
>  src/vbox/vbox_CAPI_v4_3.h     | 10210 -------------------------------
>  src/vbox/vbox_CAPI_v4_3_4.h   | 10321 --------------------------------
>  src/vbox/vbox_V4_0.c          |    37 -
>  src/vbox/vbox_V4_1.c          |    37 -
>  src/vbox/vbox_V4_2.c          |    13 -
>  src/vbox/vbox_V4_2_20.c       |    13 -
>  src/vbox/vbox_V4_3.c          |    13 -
>  src/vbox/vbox_V4_3_4.c        |    13 -
>  src/vbox/vbox_common.h        |    14 +-
>  src/vbox/vbox_storage.c       |    14 +-
>  src/vbox/vbox_tmpl.c          |   218 +-
>  src/vbox/vbox_uniformed_api.h |    10 +-
>  17 files changed, 7 insertions(+), 54101 deletions(-)
>  delete mode 100644 src/vbox/vbox_CAPI_v4_0.h
>  delete mode 100644 src/vbox/vbox_CAPI_v4_1.h
>  delete mode 100644 src/vbox/vbox_CAPI_v4_2.h
>  delete mode 100644 src/vbox/vbox_CAPI_v4_2_20.h
>  delete mode 100644 src/vbox/vbox_CAPI_v4_3.h
>  delete mode 100644 src/vbox/vbox_CAPI_v4_3_4.h
>  delete mode 100644 src/vbox/vbox_V4_0.c
>  delete mode 100644 src/vbox/vbox_V4_1.c
>  delete mode 100644 src/vbox/vbox_V4_2.c
>  delete mode 100644 src/vbox/vbox_V4_2_20.c
>  delete mode 100644 src/vbox/vbox_V4_3.c
>  delete mode 100644 src/vbox/vbox_V4_3_4.c
> 
> -- 
> 2.20.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|