[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

Daniel P. Berrangé berrange at redhat.com
Fri Apr 12 13:49:31 UTC 2019


On Fri, Apr 12, 2019 at 02:44:04PM +0200, Andrea Bolognani wrote:
> Both vim and emacs have trouble figuring out the filetype
> automatically because the name doesn't follow existing
> conventions; annotations like the ones we already have in
> Makefile.ci help them out.

I don't see any problems with emacs myself. It automatically
detects Makefile.in.am as being an automake file and activates
makefile-automake-mode without needing any special config.


> diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am
> index 6d57ca1a1b..5233a6fc08 100644
> --- a/src/access/Makefile.inc.am
> +++ b/src/access/Makefile.inc.am
> @@ -1,3 +1,6 @@
> +# -*- makefile -*-

That's plain makefile mode, which is different from makefile-automake mode
that is the one we need for these files.  I think we can just drop this
though since AFAICT it autodetects fine.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list