[libvirt] [PATCH v2 4/7] m4: readline: Extract code setting -D_FUNCTION_DEF

Daniel P. Berrangé berrange at redhat.com
Fri Apr 12 14:14:27 UTC 2019


On Tue, Apr 09, 2019 at 04:27:47PM +0200, Andrea Bolognani wrote:
> The current code is a bit awkward, and we're going to need
> to share it later anyway. We can drop the call to AC_SUBST()
> while we're at it, since LIBVIRT_CHECK_LIB() already marks
> READLINE_CFLAGS for substitution.
> 
> The new code goes to some extra length to avoid setting
> -D_FUNCTION_DEF twice: this is mostly for cosmetic reasons,
> and it's necessary because LIBVIRT_CHECK_READLINE() is called
> twice: once on its own, and then once more as part of
> LIBVIRT_CHECK_BASH_COMPLETION().

Technically theres a way to cache things so that the funcs are only
run once, but its not worth the pain of learning more m4

> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  m4/virt-readline.m4 | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list