[libvirt] [PATCH v2 6/7] m4: readline: Use pkg-config where possible

[Daniel P. Berrangé]

On Tue, Apr 09, 2019 at 04:27:49PM +0200, Andrea Bolognani wrote:
> With the 7.0 release, readline has finally started shipping
> pkg-config support in the form of a readline.pc file.
> 
> Unfortunately, most downstreams have yet to catch up with this
> change: among Linux distributions in particular, Fedora Rawhide
> seems to be the only one installing it at the moment.
> 
> Non-Linux operating systems have been faring much better in
> this regard: both FreeBSD (through ports) and macOS (through
> homebrew) include pkg-config support in their readline package.
> 
> This is great news for us, since those are the platforms where
> pkg-config is more useful on account of them installing headers
> and libraries outside of the respective default search paths.
> 
> Our implementation checks whether readline is registered as a
> pkg-config package, and if so obtains CFLAGS and LIBS using the
> tool; if not, we just keep using the existing logic.
> 
> This commit is best viewed with 'git show -w'.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  m4/virt-readline.m4 | 47 +++++++++++++++++++++++++++------------------
>  1 file changed, 28 insertions(+), 19 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|