[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am

[Daniel P. Berrangé]

On Fri, Apr 12, 2019 at 04:05:27PM +0200, Andrea Bolognani wrote:
> On Fri, 2019-04-12 at 14:49 +0100, Daniel P. Berrangé wrote:
> > On Fri, Apr 12, 2019 at 02:44:04PM +0200, Andrea Bolognani wrote:
> > > Both vim and emacs have trouble figuring out the filetype
> > > automatically because the name doesn't follow existing
> > > conventions; annotations like the ones we already have in
> > > Makefile.ci help them out.
> > 
> > I don't see any problems with emacs myself. It automatically
> > detects Makefile.in.am as being an automake file and activates
> > makefile-automake-mode without needing any special config.
> 
> Right, I assumed it would not be able to do that since it apparently
> needed the annotation for Makefile.ci.
> 
> > > +++ b/src/access/Makefile.inc.am
> > > @@ -1,3 +1,6 @@
> > > +# -*- makefile -*-
> > 
> > That's plain makefile mode, which is different from makefile-automake mode
> > that is the one we need for these files.
> 
> Turns out vim has a separate filetype (automake) for this as well!
> We ought to be use that one, of course.
> 
> > I think we can just drop this
> > though since AFAICT it autodetects fine.
> 
> Personally I'd leave both in, but I'm not an emacs user so if you
> prefer I include the vim hints only that's totally fine with me.

We previously purged emacs magic comments from all files, in favour of
the top level .dir-locals.el file. So it is best not to reintroduce
them for files which already get detected correctly.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|