[libvirt] [PATCH for v5.3.0 17/17] Revert "qemu: Temporary disable owner remembering"

Cole Robinson crobinso at redhat.com
Fri Apr 12 20:32:38 UTC 2019


On 3/28/19 11:04 AM, Michal Privoznik wrote:
> This reverts commit fc3990c7e64be1da1631952d3ec384ebef50e125.
> 
> Now that all the reported bugs are fixed let's turn the feature
> back on.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  docs/news.xml                      | 21 +++++++++++++++++++++
>  src/qemu/libvirtd_qemu.aug         |  1 +
>  src/qemu/qemu.conf                 |  5 +++++
>  src/qemu/qemu_conf.c               |  4 ++++
>  src/qemu/test_libvirtd_qemu.aug.in |  1 +
>  5 files changed, 32 insertions(+)
> 


Code wise for 11-17:

Reviewed-by: Cole Robinson <crobinso at redhat.com>

Patch 12 should drop the redundant error reporting but that doesn't need
re-review. I didn't dig deeply into call chain of the qemu mirror/rebase
bits but the code looks sane.

Patch 10 comments point out additional issues that I think should block
committing this patch though. But if you think those will be easy fixes
and want to push this first, no objections from me.

Thanks,
Cole




More information about the libvir-list mailing list