[libvirt] [PATCH] qemu: Don't cache microcode version

Ján Tomko jtomko at redhat.com
Mon Apr 15 12:31:53 UTC 2019


On Mon, Apr 15, 2019 at 12:36:52PM +0200, Jiri Denemark wrote:
>My earlier commit be46f61326 was incomplete. It removed caching of
>microcode version in the CPU driver, which means the capabilities XML
>will see the correct microcode version. But it is also cached in the
>QEMU capabilities cache where it is used to detect whether we need to
>reprobe QEMU. By missing the second place, the original commit
>be46f61326 made the situation even worse since libvirt would report
>correct microcode version while still using the old host CPU model
>(visible in domain capabilities XML).
>
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
>---
> src/qemu/qemu_capabilities.c | 12 ++++++++----
> src/qemu/qemu_capabilities.h |  3 +--
> src/qemu/qemu_driver.c       |  9 +--------
> tests/testutilsqemu.c        |  2 +-
> 4 files changed, 11 insertions(+), 15 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190415/c52c50bc/attachment-0001.sig>


More information about the libvir-list mailing list