[libvirt] [PATCH 2/2] util: Fix NAME section for virkey{code, name}-*

Martin Kletzander mkletzan at redhat.com
Mon Apr 15 14:10:30 UTC 2019


On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
>Spotted by Lintian (manpage-has-bad-whatis-entry tag).
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/util/Makefile.inc.am | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>

Makes sense, the two rules above could also have a nicer name like this one, but
that's not needed (and neither what this patch is aiming to do).

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am
>index f44d3b3b2a..c757f5a6ae 100644
>--- a/src/util/Makefile.inc.am
>+++ b/src/util/Makefile.inc.am
>@@ -321,7 +321,9 @@ util/virkeycode-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \
> 					      -e 's,\.pod,,'` && \
> 		$(MKDIR_P) util/ && \
> 		$(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \
>-		--lang pod --varname "Key code values for $$NAME" code-docs \
>+		--lang pod \
>+		--varname "virkeycode-$$NAME - Key code values for $$NAME" \
>+		code-docs \
> 		$(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \
> 			$@-tmp && mv $@-tmp $@ || rm $@-tmp
>
>@@ -331,7 +333,9 @@ util/virkeyname-%.pod: $(srcdir)/keycodemapdb/data/keymaps.csv \
> 					      -e 's,\.pod,,'` && \
> 		$(MKDIR_P) util/ && \
> 		$(PYTHON) $(srcdir)/keycodemapdb/tools/keymap-gen \
>-		--lang pod --varname "Key name values for $$NAME" name-docs \
>+		--lang pod \
>+		--varname "virkeyname-$$NAME - Key name values for $$NAME" \
>+		name-docs \
> 		$(srcdir)/keycodemapdb/data/keymaps.csv $$NAME > \
> 			$@-tmp && mv $@-tmp $@ || rm $@-tmp
>
>-- 
>2.20.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190415/e12a6801/attachment-0001.sig>


More information about the libvir-list mailing list