[libvirt] [PATCH 2/2] util: Fix NAME section for virkey{code, name}-*

Martin Kletzander mkletzan at redhat.com
Mon Apr 15 14:32:50 UTC 2019


On Mon, Apr 15, 2019 at 04:24:27PM +0200, Andrea Bolognani wrote:
>On Mon, 2019-04-15 at 16:10 +0200, Martin Kletzander wrote:
>> On Mon, Apr 15, 2019 at 03:21:01PM +0200, Andrea Bolognani wrote:
>> > Spotted by Lintian (manpage-has-bad-whatis-entry tag).
>> >
>> > Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>> > ---
>> > src/util/Makefile.inc.am | 8 ++++++--
>> > 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> Makes sense, the two rules above could also have a nicer name like this one, but
>> that's not needed (and neither what this patch is aiming to do).
>
>I'm not sure I follow... Do you mean passing a different --varname
>in the util/virkeycodetable_%.h and util/virkeynametable_%.h rules?
>We can't do that, as --varname is used as the actual variable name
>when generating C code. Or did you mean something else entirely?
>

Of course... of course I misread the rules (they all look so similar).  You are
perfectly right.

>--
>Andrea Bolognani / Red Hat / Virtualization
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190415/3f1951b5/attachment-0001.sig>


More information about the libvir-list mailing list