[libvirt] [PATCH v2 1/6] conf: Parse common scheduler attributes in separate function

[Ján Tomko]

On Mon, Apr 15, 2019 at 04:19:43PM +0200, Martin Kletzander wrote:
>On Mon, Apr 15, 2019 at 03:55:26PM +0200, Ján Tomko wrote:
>>On Mon, Apr 15, 2019 at 03:14:22PM +0200, Martin Kletzander wrote:
>>>This will become useful later when parsing emulatorsched parameters which don't
>>>need the rest of the current function.
>>>
>>>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>>>---
>>>src/conf/domain_conf.c | 70 +++++++++++++++++++++++++-----------------
>>>1 file changed, 41 insertions(+), 29 deletions(-)
>>>
>>>diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
>>>index b969a9f6e566..15838c2a23f5 100644
>>>--- a/src/conf/domain_conf.c
>>>+++ b/src/conf/domain_conf.c
>>>@@ -18441,45 +18441,24 @@ virDomainLoaderDefParseXML(xmlNodePtr node,
>>>}
>>>
>>>
>>>-static virBitmapPtr
>>>-virDomainSchedulerParse(xmlNodePtr node,
>>>-                        const char *name,
>>
>>Consider making the 'name' XML attribute mandatory only if this 'name'
>>argument is non-NULL.
>>
>
>You mean keeping the function the way it is and calling it for emulatorsched
>with NULL?  Sure, I can change that.
>

Yes.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190415/ded95e76/attachment-0001.sig>