[libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

Peter Krempa pkrempa at redhat.com
Tue Apr 16 06:32:14 UTC 2019


On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote:
> Allow passing in a 'label' string for raising errors from
> ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to
> pass in NULL to disable error reporting. We will add strings at
> a later time.

I think that rather than changing every single VIR_ENUM_IMPL you should
rather add VIR_ENUM_IMPL_TYPE or VIR_ENUM_IMPL_MSG or something like
that which will allow to use the type string.

That way it will also be far simpler to identify the places which need
fixing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190416/9613d27a/attachment-0001.sig>


More information about the libvir-list mailing list