[libvirt] [PATCH 2/3] virbuffer: Use signed integer for storing error

Michal Privoznik mprivozn at redhat.com
Thu Apr 18 12:11:24 UTC 2019


The @error member can contain a positive value (errno) or a
negative value (-1) to denote an usage error. It doesn't make
much sense to store it as unsigned then.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virbuffer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h
index fbfed5cbf3..dd9d4ab3d4 100644
--- a/src/util/virbuffer.h
+++ b/src/util/virbuffer.h
@@ -40,7 +40,7 @@ typedef virBuffer *virBufferPtr;
 struct _virBuffer {
     size_t size;
     size_t use;
-    unsigned int error; /* errno value, or -1 for usage error */
+    int error; /* errno value, or -1 for usage error */
     int indent;
     char *content;
 };
-- 
2.21.0




More information about the libvir-list mailing list