[libvirt] [PATCH v4 03/25] qemusecuritymock: Actually set error on failure

Michal Privoznik mprivozn at redhat.com
Thu Apr 25 08:19:39 UTC 2019


I don't really know what happened when I was writing the original
code, but even if error was to be set the corresponding boolean
was set to false meaning no error.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/qemusecuritymock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c
index 1ca8bd721f..e52a41067a 100644
--- a/tests/qemusecuritymock.c
+++ b/tests/qemusecuritymock.c
@@ -366,7 +366,7 @@ checkOwner(void *payload,
         fprintf(stderr,
                 "Path %s wasn't restored back to its original owner\n",
                 (const char *) name);
-        *chown_fail = false;
+        *chown_fail = true;
     }
 
     return 0;
@@ -382,7 +382,7 @@ printXATTR(void *payload,
 
     /* The fact that we are in this function means that there are
      * some XATTRs left behind. This is enough to claim an error. */
-    *xattr_fail = false;
+    *xattr_fail = true;
 
     /* Hash table key consists of "$path:$xattr_name", xattr
      * value is then the value stored in the hash table. */
-- 
2.21.0




More information about the libvir-list mailing list