[libvirt] [PATCH 3/4] qemu: On attach to live XML check for user alias collision only live XML

Michal Privoznik mprivozn at redhat.com
Fri Apr 26 13:52:22 UTC 2019


When attaching a device to live XML we don't care (well,
shouldn't care) that there's already a device in inactive XML
that has the same user alias.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_driver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2b2d531441..40fd8b9d2d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8663,7 +8663,8 @@ qemuDomainAttachDeviceLiveAndConfig(virDomainObjPtr vm,
                                                 driver->xmlopt, parse_flags)))
             goto cleanup;
 
-        if (virDomainDeviceValidateAliasForHotplug(vm, devLive, flags) < 0)
+        if (virDomainDeviceValidateAliasForHotplug(vm, devLive,
+                                                   VIR_DOMAIN_AFFECT_LIVE) < 0)
             goto cleanup;
 
         if (virDomainDefCompatibleDevice(vm->def, devLive, NULL,
-- 
2.21.0




More information about the libvir-list mailing list