[libvirt] [PATCH] test: Use nodeInfo content for virNodeGetCPUMap

Michal Privoznik mprivozn at redhat.com
Mon Apr 29 14:57:23 UTC 2019


On 4/25/19 2:57 PM, Cole Robinson wrote:
> Right now the test driver implementation of virNodeGetCPUMap uses
> hardcoded data. Instead use cpu data from our nodeInfo, which can be
> overridden with input test XML. This helps to emulate some virsh
> commands (vcpupin, hostcpumap) with a large number of host cpus. [1]
> 
> The content reported for test:///default is now slightly different:
> previously it would report 8 total cpus with 0,2,4 online. Now it
> reports 16 cpus with all online, which is the pre-existing nodeInfo
> default.
> 
> [1] https://www.redhat.com/archives/libvir-list/2019-March/msg02042.html
> 
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> John, in trying to understand and test your bitmap patch, I added
> this to the test driver. I think there's a bigger issue at play
> but I'm still trying to work it out, I'll send a follow up email
> when I've collected my thoughts
> 
>   src/test/test_driver.c | 35 +++++++++++++++++++++++++++++------
>   1 file changed, 29 insertions(+), 6 deletions(-)

ACK

Michal




More information about the libvir-list mailing list