[libvirt] [PATCH 0/5] tests: Refresh/add capabilities for QEMU 4.0.0

[Pavel Hrdina]

On Tue, Apr 30, 2019 at 02:44:06PM +0200, Andrea Bolognani wrote:
> On Tue, 2019-04-30 at 13:55 +0200, Pavel Hrdina wrote:
> > On Mon, Apr 29, 2019 at 06:25:50PM +0200, Andrea Bolognani wrote:
> > > Now that it's officially out, we can refresh existing capabilities
> > > created from git snapshots and introduce them for the architectures
> > > where they were missing altogether.
> > > 
> > > This series covers all architectures except for s390x, to which I
> > > don't have convenient access: Pino promised me he'd take care of that
> > > one in a few days.
> > > 
> > > As usual for this kind of series, most patches have been snipped with
> > > extreme prejudice in order to make them small enough that they
> > > wouldn't end up in the moderation queue: the unabridged version can
> > > be found at
> > > 
> > >   https://github.com/andreabolognani/libvirt
> > > 
> > > in the 'qemucaps-4.0.0' branch.
> > > 
> > > It'd be great if we could sneak these in during the freeze so that I
> > > won't have to possibly regenerate them again after the post-release
> > > merge flood ;)
> > 
> > Peter sent the same patch for x86_64 as well, there is one difference,
> > you also have all the Xen things enabled which would be nice to not
> > have it there since we don't care about it.
> > 
> > I acked Peter's patch so can you please re-post again with
> > --disable-xen appended to the configure of QEMU?
> 
> We might not care in RHEL, but we certainly *do* care upstream.

Not correct, sure we care about the Xen hypervisor and drivers but we
do not care about the Xen stuff in QEMU driver where we use replies.

> More specifically, I built both QEMU and libvirt on Fedora 29 after
> running 'dnf builddep' for the respective packages, so there should
> be nothing enabled that would not be enabled in the Fedora packages:
> in fact, I compared the replies and they're identical.

Yes, in fedora the Xen part is enabled because Xen uses QEMU to
emulate some aspects of the VM and Xen is supported there so the
dependencies to enable Xen support in QEMU are there by default.

> Additionally, if you check out the existing replies you'll see that
> we had Xen support compiled into QEMU when we generated those for
> versions 2.8, 2.9 and 2.10. And no, not all of those were provided
> by me... You might actually be surprised when looking at the git
> history for those files ;)

This is never a good argument :) if something was done in some way in
the past it doesn't mean that it's correct or preferred in present.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190430/42da8009/attachment-0001.sig>