[libvirt] [PATCH 1/2] test: match qemu VIR_DOMAIN_DEF_FEATURE* usage

Andrea Bolognani abologna at redhat.com
Tue Apr 30 16:20:33 UTC 2019


On Wed, 2019-04-17 at 10:57 -0400, Cole Robinson wrote:
[...]
> +    virDomainDefParserConfig config = {
> +        .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
> +                    VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
> +                    VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS |
> +                    VIR_DOMAIN_DEF_FEATURE_USER_ALIAS |
> +                    VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT |
> +                    VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING,
> +    };

virDomainDefParserConfig instances in other drivers usually follow
the (vir)${DRIVER}DomainDefParserConfig, so I would do the same here
and call it something like testDomainDefParserConfig.

Either way,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

and safe for freeze.

The second patch in the series is not as urgent, nor is it as
obviously correct, so I'll probably look at it once 5.3.0 is out.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list