[libvirt] [PATCH] tests: Fix message for IP parse/format failures

Andrea Bolognani abologna at redhat.com
Thu Aug 8 14:31:41 UTC 2019


On Thu, 2019-08-08 at 13:37 +0300, Roman Bolshakov wrote:
> Confusing message is printed when a parse/format sockettest fails. E.g.
> there's a test that parses/formats ::ffff and the format fails like that:
>   38) Test format ::ffff family AF_UNSPEC                               ...
>   Offset 2
>   Expect [0.0.255.255]
>   Actual [ffff]
> 
> It should be instead:
>   38) Test format ::ffff family AF_UNSPEC                               ...
>   Offset 2
>   Expect [ffff]
>   Actual [0.0.255.255]
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov at yadro.com>
> ---
>  tests/sockettest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch!

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

and pushed.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list