[libvirt] [PATCH v2 17/23] qemu-migration: prevent migration if dbus-vmstate is required

marcandre.lureau at redhat.com marcandre.lureau at redhat.com
Thu Aug 8 14:55:08 UTC 2019


From: Marc-André Lureau <marcandre.lureau at redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
---
 src/qemu/qemu_migration.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 7c6be201b9..86b4bfd970 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1114,6 +1114,7 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
                           bool remote,
                           unsigned int flags)
 {
+    qemuDomainObjPrivatePtr priv = vm->privateData;
     int nsnapshots;
     int pauseReason;
     size_t i;
@@ -1140,7 +1141,13 @@ qemuMigrationSrcIsAllowed(virQEMUDriverPtr driver,
                            _("cannot migrate domain with I/O error"));
             return false;
         }
+    }
 
+    if (virHashSize(priv->dbusVMStates) > 0 &&
+        !virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DBUS_VMSTATE)) {
+        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
+                       _("domain requires dbus-vmstate support"));
+        return false;
     }
 
     /* following checks don't make sense for offline migration */
-- 
2.23.0.rc1




More information about the libvir-list mailing list