[libvirt] [PATCH 03/12] qemu: fix broken handling of shallow flag in qemuDomainBlockCopyCommon

Ján Tomko jtomko at redhat.com
Mon Aug 12 13:26:04 UTC 2019


On Thu, Aug 08, 2019 at 06:00:33PM +0200, Peter Krempa wrote:
>Commit 16ca234b56fac82 refactored how the 'shallow' and 'reuse' flags
>are accessed but neglected to fix the clearing of 'shallow' in case when
>the disk has no backing chain. This means that we'd request a shallow
>copy even without backing chain and also a few checks would work wrong.
>
>Fix it by using the extracted variable everywhere.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190812/a4b252a9/attachment-0001.sig>


More information about the libvir-list mailing list