[libvirt] [PATCH 06/12] qemu: blockjob: Remove qemuBlockJobDiskRegisterMirror

Ján Tomko jtomko at redhat.com
Mon Aug 12 13:30:11 UTC 2019


On Thu, Aug 08, 2019 at 06:00:36PM +0200, Peter Krempa wrote:
>The utility of the function is extremely limited as for block copy
>we need to register the mirror chain earlier than when it's set with the
>disk. This means that it would be open-coded in that case.
>
>Avoid any weird usage and just open-code the only current usage, remove
>the function, and reword the docs.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_blockjob.c | 20 +-------------------
> src/qemu/qemu_blockjob.h |  4 ----
> src/qemu/qemu_domain.c   |  2 +-
> 3 files changed, 2 insertions(+), 24 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190812/d12b6e91/attachment-0001.sig>


More information about the libvir-list mailing list