[libvirt] [PATCH v2 0/2] Revert "configure: Remove --enable-test-coverage"

Jiri Denemark jdenemar at redhat.com
Tue Aug 13 15:49:08 UTC 2019


Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
is not a 1-1 replacement for the original configure option. Our old
--enable-test-coverage seems to be close to gnulib's make build-coverage
except gnulib runs lcov in that phase and the build actually fails for
me even before lcov is run. And since we want to be able to just build
libvirt without running lcov, I suggest reverting to our own
implementation.

I admit the best solution would be to somehow make gnulib support what
we need (and fix the actual build), but I don't feel brave enough to do
that. Eric? :-)

Also if we ever switch to glib and drop gnulib completely, we would need
to reintroduce our own implementation anyway.

I had to do some changes to resolve conflicts. The changes were not too
big, but I figured I'd rather resend this patch especially when I
originally forgot to Cc the original author of the reverted patch.

Jiri Denemark (2):
  Revert "configure: Remove --enable-test-coverage"
  Revert "docs: hacking: Add 'Code coverage reports' section"

 Makefile.am                | 20 +++++++++++++++++---
 configure.ac               | 18 ++++++++++++++++++
 docs/hacking.html.in       | 29 -----------------------------
 src/Makefile.am            |  2 ++
 src/remote/Makefile.inc.am |  2 ++
 tests/Makefile.am          |  2 ++
 tools/Makefile.am          |  6 ++++++
 7 files changed, 47 insertions(+), 32 deletions(-)

-- 
2.22.1




More information about the libvir-list mailing list