[libvirt] [PATCH 5/5] util: default to read-only in virPCIDeviceConfigOpen

Peter Krempa pkrempa at redhat.com
Thu Aug 15 09:09:16 UTC 2019


On Thu, Aug 15, 2019 at 10:10:06 +0200, Erik Skultety wrote:
> On Tue, Aug 13, 2019 at 03:45:19PM +0200, Ján Tomko wrote:
> > All the callers left require virPCIDeviceConfigOpen to be fatal
> > and only use read-only access to the config file.
> >
> > Signed-off-by: Ján Tomko <jtomko at redhat.com>
> > ---
> 
> FYI this patch broke make check, both virpcitest and virhostdevtest.

Actually it's the previous patch according to my bisection and it
happens only with gcc. Clang works fine. This hints to some inlining
weridness happening together with the pci mocking code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190815/585f194d/attachment-0001.sig>


More information about the libvir-list mailing list