[libvirt] [PATCH 2/6] qemu: Allow skipping some errors in qemuDomainStorageOpenStat

[Ján Tomko]

On Wed, Aug 14, 2019 at 06:59:17PM +0200, Peter Krempa wrote:
>Some callers of this function actually don't care about errors and reset
>it. The message is still logged which might irritate users in this case.
>
>Add a boolean flag which will do few checks whether it actually makes
>sense to even try opening the storage file. For local files we check
>whether it exists and for remote files we at first see whether we even
>have a storage driver backend for it in the first place before trying to
>open it.
>
>Other problems will still report errors but these are the most common
>scenarios which can happen here.
>
>This patch changes the return value of the function so that the caller
>is able to differentiate the possibilities.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190815/7a317d23/attachment-0001.sig>