[libvirt] [PATCH 00/14] Ignore backing files with inline authentication (blockdev-add saga)

Peter Krempa pkrempa at redhat.com
Fri Aug 16 10:39:21 UTC 2019


If a backing file string contains authentication data, many things can
break as libvirt is not tracking it since we use the secret driver for
this.

Stop considering such files as viable backing store entries.

Peter Krempa (14):
  util: storage: Simplify cleanup path handling in
    virStorageSourceParseBackingJSONInternal
  util: storagefile: Remove cleanup label from
    virStorageSourceParseBackingJSONiSCSI
  util: storagefile: Simplify cleanup handling in
    virStorageSourceParseBackingURI
  util: storagefile: Simplify cleanup in
    virStorageSourceParseBackingJSON
  tests: viruri: Add test for password in URI userinfo
  tests: storage: Refactor cleanup in testBackingParse
  util: storage: Modify return value of virStorageSourceNewFromBacking
  util: storagefile: Preserve return value in
    virStorageSourceParseBackingJSONUriStr
  util: storagefile: Modify arguments of
    virStorageSourceNewFromBackingAbsolue
  tests: virstorage: Allow testing return value of
    virStorageSourceNewFromBackingAbsolute
  util: storagefile: Add handling of unusable storage sources
  util: storagefile: Clarify docs for '@report_broken' of
    virStorageFileGetMetadata
  util: storagefile: Don't traverse storage sources unusable by VM
  util: storagefile: Flag backing store strings with authentication

 src/storage/storage_util.c |   2 +-
 src/util/virstoragefile.c  | 215 ++++++++++++++++++++++---------------
 src/util/virstoragefile.h  |   7 +-
 tests/qemublocktest.c      |   3 +-
 tests/virstoragetest.c     |  66 +++++++++---
 tests/viruritest.c         |   1 +
 6 files changed, 185 insertions(+), 109 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list