[libvirt] [PATCH 07/18] virpcimock: Rename @fakesysfspcidir

Daniel Henrique Barboza danielhb413 at gmail.com
Fri Aug 16 21:07:27 UTC 2019


Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

On 8/14/19 8:57 AM, Michal Privoznik wrote:
> We will need to create more directories and instead of
> introducing bunch of new variables to hold their actual
> paths, we can have one and reuse it.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>   tests/virpcimock.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/virpcimock.c b/tests/virpcimock.c
> index 296da9b453..e97dbd81f8 100644
> --- a/tests/virpcimock.c
> +++ b/tests/virpcimock.c
> @@ -831,7 +831,7 @@ init_syms(void)
>   static void
>   init_env(void)
>   {
> -    VIR_AUTOFREE(char *) fakesysfspcidir = NULL;
> +    VIR_AUTOFREE(char *) tmp = NULL;
>   
>       if (fakerootdir)
>           return;
> @@ -839,14 +839,14 @@ init_env(void)
>       if (!(fakerootdir = getenv("LIBVIRT_FAKE_ROOT_DIR")))
>           ABORT("Missing LIBVIRT_FAKE_ROOT_DIR env variable\n");
>   
> -    if (virAsprintfQuiet(&fakesysfspcidir, "%s%s",
> +    if (virAsprintfQuiet(&tmp, "%s%s",
>                            fakerootdir, SYSFS_PCI_PREFIX) < 0)
>           ABORT_OOM();
>   
> -    if (virFileMakePath(fakesysfspcidir) < 0)
> -        ABORT("Unable to create: %s", fakesysfspcidir);
> +    if (virFileMakePath(tmp) < 0)
> +        ABORT("Unable to create: %s", tmp);
>   
> -    make_file(fakesysfspcidir, "drivers_probe", NULL, -1);
> +    make_file(tmp, "drivers_probe", NULL, -1);
>   
>   # define MAKE_PCI_DRIVER(name, ...) \
>       pci_driver_new(name, 0, __VA_ARGS__, -1, -1)




More information about the libvir-list mailing list