[libvirt] [PATCH 04/12] qemu: Drop unused qemuOpenPCIConfig()
Daniel Henrique Barboza
danielhb413 at gmail.com
Tue Aug 20 17:40:35 UTC 2019
On 8/20/19 11:30 AM, Michal Privoznik wrote:
> After previous commits, the function is not used anymore.
> Remove it.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> src/qemu/qemu_command.c | 22 ----------------------
> src/qemu/qemu_command.h | 2 --
> 2 files changed, 24 deletions(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index f7b5430db8..500ffff035 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -4878,28 +4878,6 @@ qemuBuildVideoCommandLine(virCommandPtr cmd,
> }
>
>
> -int
> -qemuOpenPCIConfig(virDomainHostdevDefPtr dev)
> -{
> - virDomainHostdevSubsysPCIPtr pcisrc = &dev->source.subsys.u.pci;
> - char *path = NULL;
> - int configfd = -1;
> -
> - if (virAsprintf(&path, "/sys/bus/pci/devices/%04x:%02x:%02x.%01x/config",
> - pcisrc->addr.domain, pcisrc->addr.bus,
> - pcisrc->addr.slot, pcisrc->addr.function) < 0)
> - return -1;
> -
> - configfd = open(path, O_RDWR, 0);
> -
> - if (configfd < 0)
> - virReportSystemError(errno, _("Failed opening %s"), path);
> -
> - VIR_FREE(path);
> -
> - return configfd;
> -}
> -
> char *
> qemuBuildPCIHostdevDevStr(const virDomainDef *def,
> virDomainHostdevDefPtr dev,
> diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h
> index e3983bedb2..6f97e7bc0c 100644
> --- a/src/qemu/qemu_command.h
> +++ b/src/qemu/qemu_command.h
> @@ -157,8 +157,6 @@ int qemuBuildRNGBackendProps(virDomainRNGDefPtr rng,
> virQEMUCapsPtr qemuCaps,
> virJSONValuePtr *props);
>
> -int qemuOpenPCIConfig(virDomainHostdevDefPtr dev);
> -
> /* Current, best practice */
> char *qemuBuildUSBHostdevDevStr(const virDomainDef *def,
> virDomainHostdevDefPtr dev,
More information about the libvir-list
mailing list