[libvirt] [PATCH 03/21] prepare: domain format if format not href

[Jiri Denemark]

On Wed, Aug 21, 2019 at 01:15:25 +0200, Ján Tomko wrote:
> ---
>  src/conf/domain_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 1f2a91c710..f848483235 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -28312,7 +28312,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
>      virBufferAsprintf(buf, "<domain type='%s'", type);
>      if (!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE))
>          virBufferAsprintf(buf, " id='%d'", def->id);
> -    if (def->namespaceData && def->ns.href)
> +    if (def->namespaceData && def->ns.format)
>          virBufferAsprintf(buf, " %s", (def->ns.href)());
>      virBufferAddLit(buf, ">\n");
>      virBufferAdjustIndent(buf, 2);

Checking def->ns.format when you want to call def->ns.href doesn't make
sense. Did you perhaps wanted to check for both as formatting the
namespace attribute useless when no XML using it will be formatted?

Jirka