[libvirt] [PATCH 11/14] util: storagefile: Add handling of unusable storage sources

Ján Tomko jtomko at redhat.com
Wed Aug 21 15:15:54 UTC 2019


On Fri, Aug 16, 2019 at 12:39:32PM +0200, Peter Krempa wrote:
>Introduce new semantics to virStorageSourceNewFromBacking and some
>of the helpers used by it which propagate the return value from the
>callers.
>
>The new return value introduced by this patch allows to notify the
>calller that the parsed virStorageSource correctly describes the source
>but contains data such as inline authentication which libvirt does not
>want to support directly. This means that such file would e.g. unusable
>as a storage source (e.g. when actively commiting the overlay to it) or
>would not work with blockdev.
>
>The caller will then be able to decide whether to consider this backing
>file as viable or just fall back to qemu dealing with it.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virstoragefile.c | 30 ++++++++++++++++++++++--------
> 1 file changed, 22 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190821/3059339b/attachment-0001.sig>


More information about the libvir-list mailing list