[libvirt] [PATCH 13/14] util: storagefile: Don't traverse storage sources unusable by VM

Ján Tomko jtomko at redhat.com
Wed Aug 21 15:18:37 UTC 2019


On Fri, Aug 16, 2019 at 12:39:34PM +0200, Peter Krempa wrote:
>virStorageFileGetMetadataRecurse would include in the backing chain
>files which would not really be usable by libvirt directly e.g. when

include files in the backing chain

>such file would be promoted to the top layer by a active block commit as

an active

>for example inline authentication data can't be represented in the VM
>xml file. The idea is to use secrets for this.
>
>With the changes to the backing store string parsers we can report and
>propagate if such a thing is present in the configuration and thus start
>skipping those files in the backing chain traversal code. This approach
>still allows to report the appropriate backing store string in the
>storage driver which doesn't directly use the backing file.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virstoragefile.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190821/5df759da/attachment-0001.sig>


More information about the libvir-list mailing list