[libvirt] [PATCH 14/14] util: storagefile: Flag backing store strings with authentication

[Ján Tomko]

On Fri, Aug 16, 2019 at 12:39:35PM +0200, Peter Krempa wrote:
>Using inline authentication for storage volumes will not work properly
>as libvirt requires use of the secret driver for the auth data and
>thus would not be able to represent the passwords stored in the backing
>store string.
>
>Make sure that the backing store parsers return 1 which is a sign for
>the caller to not use the file in certain cases.
>
>The test data include iscsi via a json pseudo-protocol string and URIs
>with the userinfo part being present.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virstoragefile.c | 11 +++++++++--
> tests/virstoragetest.c    | 28 ++++++++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190821/0eb5cbb7/attachment-0001.sig>