[libvirt] [PATCH] storage_driver: Don't crash in storagePoolCreateXML

Martin Kletzander mkletzan at redhat.com
Fri Aug 23 13:31:40 UTC 2019


On Fri, Aug 23, 2019 at 03:24:43PM +0200, Michal Privoznik wrote:
>In my recent patches I've introduced
>virStoragePoolObjIsStarting() which is then used to protect
>storage pool definition when the pool object is locked and
>unlocked during long running jobs. Well, my patches did not
>anticipate that @obj can be NULL under 'cleanup' label in
>storagePoolCreateXML() (for instance when parsing XML fails).
>This imperfection is causing libvirtd to crash then.
>
>Fixes: 13284a6b83 storage_driver: Protect pool def during startup and build
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190823/1af0c6c1/attachment-0001.sig>


More information about the libvir-list mailing list