[libvirt] [PATCH v4 27/42] libxl: introduce virtxend daemon

[Daniel P. Berrangé]

On Fri, Aug 23, 2019 at 05:11:18PM +0000, Jim Fehlig wrote:
> On 8/8/19 9:10 AM, Daniel P. Berrangé  wrote:
> > Arguably we could rename the libxl driver to "xen" since it is the
> > only xen driver we have these days, and that matches how we expose it
> > to users in the URI naming.
> 
> While thinking about this today I realized it is actually quite a rat hole. I 
> started by making a list of tasks associated with the rename
> 
> - Replace 'libxl' with 'xen' in the docs
> - Change configure option to '--with-xen' and drop '--with-libxl'
> - Rename virt-driver-libxl.m4 to virt-driver-xen.m4
> - Rename src/libxl to src/xen
> - Rename src/xen/libxl_*.[ch] to src/xen/xen_*.[ch}
> - Rename all the libxl files under tests/
> 
> These are easy enough, but should the list continue with renaming functions in 
> all those files? And what about things that are not so easy to rename, e.g. 
> runtime directories such as /etc/libvirt/libxl, /var/lib/libvirt/libxl/, 
> /var/log/libvirt/libxl, etc. Would renaming some things but leaving others cause 
> more confusion than the current situation?

Yeah the directory paths is where it gets "interesting", as we would need
to move files during the upgrade process. We've done that once before when
we moved from $HOME/.libvirt to the XDG directory layout. We had a startup
method in libvirtdm which i finally killed recently in
e10310d641365c83f4588670ac57e93d032db7f4

The libxl conversion would need to move more directories.

Where it might get especially painful is if there are things you cannot move
while VMs are running ?

I don't have a strong opinion either way - do whatever level of renaming
makes most sense to you.

> Regardless of how far to go with renaming libxl to xen, I think moving the 
> xen<->libvirt config converter files from src/xenconfig to src/libxl and nuking 
> the xenconfig directory is a worthy endeavor.

Sure, makes sense.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|