[libvirt] [PATCH 2/9] tests: Always put '\n' at the end of VIR_TEST_VERBOSE

Ján Tomko jtomko at redhat.com
Mon Aug 26 12:14:57 UTC 2019


On Mon, Aug 12, 2019 at 01:54:18PM +0200, Michal Privoznik wrote:
>Similarly to the previous commit, VIR_TEST_VERBOSE should put
>'\n' at the end of each call so that the output is not broken.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tests/cputest.c                  | 14 +++---
> tests/qemublocktest.c            | 10 ++---
> tests/qemuhotplugtest.c          | 10 ++---
> tests/qemumonitorjsontest.c      |  8 ++--
> tests/securityselinuxlabeltest.c |  4 +-
> tests/testutils.h                |  4 +-
> tests/testutilsqemu.c            |  9 ++--
> tests/testutilsqemuschema.c      |  8 ++--
> tests/virerrortest.c             | 12 +++---
> tests/virhashtest.c              | 18 ++++----
> tests/virjsontest.c              | 74 ++++++++++++++++----------------
> 11 files changed, 87 insertions(+), 84 deletions(-)
>
>diff --git a/tests/testutils.h b/tests/testutils.h
>index cfc60084b2..2d0cea7826 100644
>--- a/tests/testutils.h
>+++ b/tests/testutils.h
>@@ -97,8 +97,10 @@ unsigned int virTestGetRegenerate(void);
>
> #define VIR_TEST_VERBOSE(...) \
>     do { \
>-        if (virTestGetVerbose()) \
>+        if (virTestGetVerbose()) { \
>             fprintf(stderr, __VA_ARGS__); \
>+            fprintf(stderr, "\n"); \
>+        } \
>     } while (0)
>
> char *virTestLogContentAndReset(void);

This macro is not used enough to reach the limit, but if you make the
change in the first patch, please change this one as well.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190826/3d74683b/attachment-0001.sig>


More information about the libvir-list mailing list