[libvirt] [PATCH 4/9] virhostdevtest: Check for integer retval in more verbose way

Ján Tomko jtomko at redhat.com
Mon Aug 26 12:21:27 UTC 2019


On Mon, Aug 12, 2019 at 01:54:20PM +0200, Michal Privoznik wrote:
>From: Michal Privoznik <miso.privoznik at gmail.com>
>

The e-mail here does not match the one in the signoff

>There are few functions called from the test which return an
>integer but their retval is compared as if it was a pointer.
>Now, there is nothing wrong with that from machine POV, but
>from readability perspective it's wrong.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> tests/virhostdevtest.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190826/ed56c9a1/attachment-0001.sig>


More information about the libvir-list mailing list