[libvirt] [PATCH 09/19] qemu_command: use VIR_AUTOFREE for variables used once

[Ján Tomko]

On Wed, Aug 21, 2019 at 09:44:05AM +0200, Michal Privoznik wrote:
>On 8/20/19 2:59 PM, Ján Tomko wrote:
>>Remove the VIR_FREE's from the cleanup sections.
>>
>>Signed-off-by: Ján Tomko <jtomko at redhat.com>
>>---
>>  src/qemu/qemu_command.c | 207 +++++++++++++---------------------------
>>  1 file changed, 66 insertions(+), 141 deletions(-)
>>
>>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>>index b5448a074f..fe06867a88 100644
>>--- a/src/qemu/qemu_command.c
>>+++ b/src/qemu/qemu_command.c
>
>Missing: qemuBuildControllersByTypeCommandLine, 

Dealt with in a later patch of this series.

>qemuBuildSoundCommandLine

I will sent this in a followup series.

>qemuBuildRNGCommandLine,

Dealt with in a later patch of this series.

>qemuBuildSmbiosCommandLine
>

Sorry, I can't figure out how to make that function nicer with
VIR_AUTOFREE (and I was told not to combine VIR_AUTOFREE with VIR_FREE).

Jano

>Maybe you are doing that (and other suggestions I have for this patch) 
>in next patches. If so, disregard me.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190826/7a1604df/attachment-0001.sig>