[libvirt] [PATCH 17/19] qemu_command: remove unnecessary labels and ret variables

Ján Tomko jtomko at redhat.com
Mon Aug 26 20:44:32 UTC 2019


On Wed, Aug 21, 2019 at 09:44:01AM +0200, Michal Privoznik wrote:
>On 8/20/19 2:59 PM, Ján Tomko wrote:
>>The recent cleanups allow us to clean up the code a bit.
>>
>>Signed-off-by: Ján Tomko <jtomko at redhat.com>
>>---
>>  src/qemu/qemu_command.c | 741 +++++++++++++++-------------------------
>>  1 file changed, 274 insertions(+), 467 deletions(-)
>
>qemuBuildMemoryBackendProps
>qemuBuildMemoryCellBackendStr

The ret usage there does not closely follow the usual mechanical pattern
so I sent those separately.

>qemuBuildHostNetStr (if you take mu suggestion from previous patch and 
>use VIR_AUTOUNREF() for @cfg)

Actually, doing that shows that cfg has been unused for a few years
there.
Dealt with separately.

Jano

>
>Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190826/ecf82d04/attachment-0001.sig>


More information about the libvir-list mailing list