[libvirt] [PATCH] qemu: use 'bochs' video type by default for UEFI domains

[Andrea Bolognani]

On Thu, 2019-08-29 at 08:22 +0200, Peter Krempa wrote:
> On Wed, Aug 28, 2019 at 16:52:39 -0500, Jonathon Jongsma wrote:
> > @@ -7452,6 +7455,8 @@ qemuDomainDeviceVideoDefPostParse(virDomainVideoDefPtr video,
> >                   qemuDomainIsRISCVVirt(def) ||
> >                   ARCH_IS_S390(def->os.arch))
> >              video->type = VIR_DOMAIN_VIDEO_TYPE_VIRTIO;
> > +        else if (qemuDomainDefIsUEFI(def))
> > +            video->type = VIR_DOMAIN_VIDEO_TYPE_BOCHS;
> 
> 'bochs-display' seems to be supported starting qemu 3.0.0, but
> pflash/ovmf starting qemu 1.7, so this can result in invalid
> configuration for older qemu versions.

Agreed, we can't just change the default like this.

If we want new guests to use bochs-display, then that needs to be
wired up in virt-manager in a way that's conditional to support being
available both on the host and in the guest.

Incidentally, and I haven't followed this closely so apologies if I'm
asking a silly question, if the point of bochs-display is to have a
video device without legacy VGA emulation then why aren't we using
the existing virtio-gpu, which has been around a lot longer and has
better support throughout the stack, instead?

Please by all means *do* send the patch introducing
qemuDomainDefIsUEFI() separately, it's a pretty nice cleanup.

-- 
Andrea Bolognani / Red Hat / Virtualization