[libvirt] [PATCH v2 0/9] qemu: Blockdevize external snapshot creation (blokcdev-add saga)

Peter Krempa pkrempa at redhat.com
Thu Aug 29 14:12:45 UTC 2019


Patches 1-5 of the original series were already pushed.

Patches 1-3 of this series are new and deal with fixing of a image
locking bug which was added during the blockdev-add saga as we've
changed the handling of the 'readonly' flag of an image.

Patch 4 is new and should solve review feedback which complained about
function naming.

The rest of the series is almost exactly as in previous posting with
following exceptions:

1) Review feedback incorporated and R-b's applied.
2) Patch 6/9 has a different summary
3) Patch 8/9 fixes a memory leak/crash as a part of the cleanup was
   misplaced out of the cleaning loop (while still using the 'i' to
   dereference arrays).
4) Conflicts with 4/9 resolved.

Peter Krempa (9):
  qemu: snapshot: Fix image lock handling when taking a snapshot
  qemu: snapshot: Save status and config XMLs only on success
  qemu: snapshot: Move error preservation to
    qemuDomainSnapshotDiskDataCleanup
  qemu: snapshot: Rename external disk snapshot handling functions
  qemu: Disband qemuDomainSnapshotCreateSingleDiskActive
  qemu: Merge use of 'reuse' flag in qemuDomainSnapshotDiskPrepareOne
  qemu: snapshot: Skip overlay file creation/interogation if unsupported
  qemu: Add -blockdev support for external snapshots
  qemu: Defer support checks for external active snapshots to blockdev
    code or qemu

 src/qemu/qemu_driver.c | 276 +++++++++++++++++++++++++----------------
 1 file changed, 171 insertions(+), 105 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list