[libvirt] [PATCH 1/3] qemu: block: Use correct type when creating image size JSON entries

Ján Tomko jtomko at redhat.com
Fri Aug 30 14:58:59 UTC 2019


On Fri, Aug 30, 2019 at 04:45:03PM +0200, Peter Krempa wrote:
>The 'u' modifier creates a unsigned int JSON attribute but the disk size

an unsigned

>and capacity fields are unsigned long long. If the size of the created
>image would be more than 4GiB we'd overflow and create sub-4G image.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_block.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Depending on how broken things get,
qemuBlockStorageSourceGetGlusterProps might need a similar change ;)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190830/fbb42352/attachment-0001.sig>


More information about the libvir-list mailing list