[libvirt] [PATCH v2 2/2] rng: Extend the valid range of drive unit

[Han Han]

On Tue, Dec 3, 2019 at 1:40 AM Boris Fiuczynski <fiuczy at linux.ibm.com>
wrote:

> On 12/2/19 9:41 AM, Han Han wrote:
> > In the last commit, we allowed unit number of virtio scsi disk to use
> > range 0..16383. Extend the range in rng file to match that.
> >
> > Signed-off-by: Han Han <hhan at redhat.com>
> > ---
> >   docs/schemas/domaincommon.rng | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/schemas/domaincommon.rng
> b/docs/schemas/domaincommon.rng
> > index a83c9ae7a5..17efcfdcb0 100644
> > --- a/docs/schemas/domaincommon.rng
> > +++ b/docs/schemas/domaincommon.rng
> > @@ -6460,7 +6460,7 @@
> >     </define>
> >     <define name="driveUnit">
> >       <data type="string">
> > -      <param name="pattern">[0-9]{1,2}</param>
> > +      <param name="pattern">[0-9]{1,5}</param>
> Let me repeat my remark on v1 on v2 as well:
> This changes also virtio-serial (port attribute is 2-digit) and ccid
> addresses (slot attribute is 2-digit). So you need a separate definition
> of the pattern for drive address.
>
Thank you for pointing it out. I will update it in next version

>
> >       </data>
> >     </define>
> >     <define name="driveSCSIUnit">
> >
>
>
> --
> Mit freundlichen Grüßen/Kind regards
>     Boris Fiuczynski
>
> IBM Deutschland Research & Development GmbH
> Vorsitzender des Aufsichtsrats: Matthias Hartmann
> Geschäftsführung: Dirk Wittkopp
> Sitz der Gesellschaft: Böblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294
>
>

-- 
Best regards,
-----------------------------------
Han Han
Quality Engineer
Redhat.

Email: hhan at redhat.com
Phone: +861065339333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191203/9db64c0e/attachment-0001.htm>