[libvirt] [jenkins-ci PATCH] lcitool: Explain our use of the 'ks' kernel parameter

Andrea Bolognani abologna at redhat.com
Tue Dec 3 11:19:55 UTC 2019


It's not immediately obvious why we're using it even when installing
a distribution like Debian, so explain the motivation in a comment.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 guests/lcitool | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guests/lcitool b/guests/lcitool
index a630971..0e27796 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -540,7 +540,9 @@ class Application:
             # preseed files must use a well-known name to be picked up by
             # d-i; for kickstart files, we can use whatever name we please
             # but we need to point anaconda in the right direction through
-            # a kernel argument
+            # the 'ks' kernel parameter. We can use 'ks' unconditionally
+            # for simplicity's sake, because distributions that don't use
+            # kickstart for unattended installation will simply ignore it
             extra_arg = "console=ttyS0 ks=file:/{}".format(install_config)
 
             virt_install = distutils.spawn.find_executable("virt-install")
-- 
2.23.0




More information about the libvir-list mailing list