[libvirt] [PATCH v2 07/25] backup: Implement backup APIs for remote driver

Ján Tomko jtomko at redhat.com
Mon Dec 9 14:45:04 UTC 2019


On Tue, Dec 03, 2019 at 06:17:29PM +0100, Peter Krempa wrote:
>From: Eric Blake <eblake at redhat.com>
>
>This one is fairly straightforward - the generator already does what
>we need.
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/remote/remote_driver.c   |  2 ++
> src/remote/remote_protocol.x | 33 ++++++++++++++++++++++++++++++++-
> src/remote_protocol-structs  | 15 +++++++++++++++
> 3 files changed, 49 insertions(+), 1 deletion(-)
>
>diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
>index a1384fc655..ddb95914a6 100644
>--- a/src/remote/remote_driver.c
>+++ b/src/remote/remote_driver.c
>@@ -8702,6 +8702,8 @@ static virHypervisorDriver hypervisor_driver = {
>     .domainCheckpointDelete = remoteDomainCheckpointDelete, /* 5.6.0 */
>     .domainGetGuestInfo = remoteDomainGetGuestInfo, /* 5.7.0 */
>     .domainAgentSetResponseTimeout = remoteDomainAgentSetResponseTimeout, /* 5.10.0 */
>+    .domainBackupBegin = remoteDomainBackupBegin, /* 6.0.0 */
>+    .domainBackupGetXMLDesc = remoteDomainBackupGetXMLDesc, /* 6.0.0 */
> };
>
> static virNetworkDriver network_driver = {
>diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
>index 23e42d17b1..c79cb98ae8 100644
>--- a/src/remote/remote_protocol.x
>+++ b/src/remote/remote_protocol.x
>@@ -3754,6 +3754,23 @@ struct remote_domain_agent_set_response_timeout_ret {
>     int result;
> };
>
>+
>+struct remote_domain_backup_begin_args {
>+    remote_nonnull_domain dom;
>+    remote_string backup_xml;

Should this be remote_nonnull_string?

>+    remote_string checkpoint_xml;
>+    unsigned int flags;
>+};
>+

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191209/db39823a/attachment-0001.sig>


More information about the libvir-list mailing list